-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor user customization test improvements #4007
Conversation
ac36323
to
bda14f2
Compare
bda14f2
to
bb4f711
Compare
bb4f711
to
1afaf35
Compare
osbuild/images got a tag with the necessary changes, so I have updated this PR to depend on that tag and I also made a doc change PR, so I think this is ready to go. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looks like you accidentally squashed your commit into the image update commit, there's only one commit now.
f7f2ef7
to
f36902a
Compare
This has been a single commit I think since I opened it. I think you may be thinking of my PR in osbuild/images that had a separate commit for the go fmt change, so I will do the same thing here. |
Done. Go fmt changes to customizations_test.go are separated into their own commit. |
ab701e8
to
4adc0b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now I see 2 commits. But the one with the title 'Update osbuild/image to v0.51.0' isn't doing that. And the body of it says it is doing things to user customizations when all it is doing is adding the field to the customizations test. So the commit message on that one needs to be fixed.
A different PR that bumped osbuild/images up to v0.51.0 got merged already (1ce7207) and when I rebased the source branch of this PR on top of the target branch it eliminated 95% of the changes and only some inconsequential bits are left. If you still want the little bits that are left I can fix the commit messages. If you don't I can close it. What do you prefer? |
yeah, seems worthwhile to clean things up, thanks! |
4adc0b3
to
032ee1f
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Looks like some checks need to be rerun |
3a766b5
to
a3ddea2
Compare
a3ddea2
to
602f37b
Compare
Extend user customizations to include an expiration date. This allows users to be configured to require password change on first login.
This pull request includes: