templates/openshift: make the maintenance template generic

[croissanne]

We could deploy this job for both composer and each tenant's workers that's present in app-intf. Then we can remove the maintenance bits from the composer template.

[schuellerf]

Will the DB maintenance then be remove from the composer.yml?

[croissanne]

Will the DB maintenance then be remove from the composer.yml?

exactly, we'll just deploy the maintenance template twice, once for composer and once for the workers.

- name: maintenance
  url: https://github.com/osbuild/osbuild-composer
  path: /templates/maintenance.yml
  targets:
  - namespace:
      $ref: /services/image-builder/namespaces/workers-stage.yml
    upstream:
      instance:
        $ref: /dependencies/ci-ext/ci-ext.yml
      name: osbuild-osbuild-composer-gh-build-main
    ref: main
    parameters:
      PGSSLMODE: "require"
      MAINTENANCE_DRY_RUN: "true"
      ENABLE_AWS_MAINTENANCE: "true"
      ENABLE_GCP_MAINTENANCE: "true"
  - namespace:
      $ref: /services/image-builder/namespaces/composer-stage.yml
    upstream:
      instance:
        $ref: /dependencies/ci-ext/ci-ext.yml
      name: osbuild-osbuild-composer-gh-build-main
    ref: main
    parameters:
      PGSSLMODE: "require"
      MAINTENANCE_DRY_RUN: "true"
      ENABLE_DB_MAINTENANCE: "true"

this is what we'd do in app-intf

[schuellerf]

probably with

- name: maintenance
  url: https://github.com/osbuild/osbuild-composer
  path: /templates/maintenance.yml
  targets:
  - namespace:
      $ref: /services/image-builder/namespaces/workers-stage.yml
    upstream:
      instance:
        $ref: /dependencies/ci-ext/ci-ext.yml
      name: osbuild-osbuild-composer-gh-build-main
    ref: main
    parameters:
      PGSSLMODE: "require"
      MAINTENANCE_DRY_RUN: "true"
      ENABLE_AWS_MAINTENANCE: "true"
      ENABLE_GCP_MAINTENANCE: "true"
>      ENABLE_DB_MAINTENANCE: "false"
  - namespace:
      $ref: /services/image-builder/namespaces/composer-stage.yml
    upstream:
      instance:
        $ref: /dependencies/ci-ext/ci-ext.yml
      name: osbuild-osbuild-composer-gh-build-main
    ref: main
    parameters:
      PGSSLMODE: "require"
      MAINTENANCE_DRY_RUN: "true"
      ENABLE_DB_MAINTENANCE: "true"

as ENABLE_DB_MAINTENANCE is mandatory, right? 🤔

[schuellerf]

LGTM

[croissanne]

as ENABLE_DB_MAINTENANCE is mandatory, right? 🤔

yea but the template sets it to false by default (required & default value just prevent it from being set to "")