Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientdetails: handle error interfaces in Details somewhat #4137

Closed
wants to merge 4 commits into from
Closed

clientdetails: handle error interfaces in Details somewhat #4137

wants to merge 4 commits into from

Commits on May 13, 2024

  1. clientdetails: add test for error reporting 

    We have no tests for the clienterror, start with a trivial one.
    @mvo5
    mvo5 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9160dc3 View commit details
    Browse the repository at this point in the history

  2. clienterrors: add (failing) test to reproduce error interface handling

    @mvo5
    mvo5 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4165bf4 View commit details
    Browse the repository at this point in the history

  3. clienterrors: add (one possible) way to fix the missing errors

    @mvo5
    mvo5 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d4300fc View commit details
    Browse the repository at this point in the history

  4. clienterrors: detect and error on deeply nested errors 

    Florian pointed out that `clienterror.Error.Details` could contain
arbitrarily deeply nested error values. Add code to detect this.

Also deal with the (common?) case that `.Details` contains a list
of errors.
    @mvo5
    mvo5 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7a862d4 View commit details
    Browse the repository at this point in the history