-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to oaas / osbuild-worker-executor (HMS-4097) #4184
Conversation
25298d5
to
304f7a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a quick drive-by comment, it might be nice if the first commit with the copy of oaas also points to the original repo url in the description (that will then be archived). Just so that the git history is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I'm very excited! I did a quick runthrough and added some small sugestions/ideas, mostly drive-by. Super happy to help out here too, I would love for example to write some tests for runner-impl-aws-ec2.go :)
e64167b
to
1d877c1
Compare
ce4111c
to
74ca920
Compare
63163c3
to
0661cbc
Compare
63bbb44
to
34fe3e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks really nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good (after the rebase)
Adds some unit tests as well.
In RunOsbuild return more verbose errors where the error doesn't originate from one of the local helper functions.
This commit fixes a warning from tar that the archive cannot contain itself. It also makes any tar output a warning (maybe even an error?) as we do not expect anything from the tar command. The test is updated to also check this.
The tar file from the `osbuild-worker-executor` is potentially tainted. Ensure we validate and only extract if it harmless.
got applied in the rebase again, reverted that, not sure where ._. |
Otherwise the client will try to fetch the output archive before the build output is archived on the worker-executor side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This simplifies the way the worker-executor, there's only 3 http calls happening: wait until ready, post for a build, get for the results.