Introduce make lint #4228
Merged
Introduce make lint #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuellerf
force-pushed
the
introduce_make_lint
branch
3 times, most recently
from
d1b1b76
to
777b018
Compare
schuellerf
force-pushed
the
introduce_make_lint
branch
4 times, most recently
from
8a21b62
to
8cb1080
Compare
achilleas-k
reviewed
Jun 25, 2024
mvo5
reviewed
Jun 25, 2024
schuellerf
force-pushed
the
introduce_make_lint
branch
from
8cb1080
to
c5cebd5
Compare
|
Fedora 38 RPM builds are failing but F38 is EOL so let's just drop them. |
achilleas-k
force-pushed
the
introduce_make_lint
branch
from
c5cebd5
to
515f676
Compare
|
how to re-run the gitlab pipelines? I think the PR should be fine |
achilleas-k
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to reproduce
golangci-linterrors with the newmake lintand fix them