Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.21 and update osbuild/images to v0.69.0 #4241

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

achilleas-k
Copy link
Member

go.mod: update to go v1.21

Go 1.21 is included in all currently supported distro versions.
It is required by new updates to some of our dependencies, including
osbuild/images.


go.mod: update osbuild/images to v0.69.0


weldr: update expected error messages

Some depsolve-related error messages in osbuild/images changed. Update
the expected error messages in our tests.


thozza
thozza previously approved these changes Jul 2, 2024
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

croissanne
croissanne previously approved these changes Jul 3, 2024
@achilleas-k
Copy link
Member Author

Tests failing with

✔️ Instance checking
Warning: Permanently added '129.213.58.207' (ECDSA) to the list of known hosts.
postgresql-10.23-4.module+el8.9.0+21317+d2c6bf8a.x86_64
dummy-1.0.0-0.noarch
System is subscribed.
Unregistering from: subscription.rhsm.redhat.com:443/subscription
System has been unregistered.
✔️ Checking custom directories and files
✔️ Checking custom repositories
✔️ Checking OpenSCAP customizations
cat: /usr/share/xml/osbuild-openscap-data/tailoring.xml: No such file or directory

@kingsleyzissou Is this related to recent oscap changes in osbuild/images? Either v0.68.0 or v0.69.0?

@kingsleyzissou
Copy link
Contributor

kingsleyzissou commented Jul 4, 2024

Tests failing with

✔️ Instance checking
Warning: Permanently added '129.213.58.207' (ECDSA) to the list of known hosts.
postgresql-10.23-4.module+el8.9.0+21317+d2c6bf8a.x86_64
dummy-1.0.0-0.noarch
System is subscribed.
Unregistering from: subscription.rhsm.redhat.com:443/subscription
System has been unregistered.
✔️ Checking custom directories and files
✔️ Checking custom repositories
✔️ Checking OpenSCAP customizations
cat: /usr/share/xml/osbuild-openscap-data/tailoring.xml: No such file or directory

@kingsleyzissou Is this related to recent oscap changes in osbuild/images? Either v0.68.0 or v0.69.0?

Yeah, I fixed the test (in images), but we moved the tailoring file to /oscap_data since all the osbuild stage saves all the artifacts there.

Edit: had to check which repo we were in, thought this was for images.

@achilleas-k
Copy link
Member Author

Yeah, I fixed the test (in images), but we moved the tailoring file to /oscap_data since all the osbuild stage saves all the artifacts there.

So is it enough to update the path in the test to look for the file in /oscap_data? Just confirming before I start the CI runs again.

@kingsleyzissou
Copy link
Contributor

Yeah, I fixed the test (in images), but we moved the tailoring file to /oscap_data since all the osbuild stage saves all the artifacts there.

So is it enough to update the path in the test to look for the file in /oscap_data? Just confirming before I start the CI runs again.

Yeah, as far as I can see we aren't running any scans. So changing it to /oscap_data/tailoring.xml should be enough. Here is the commit from images: osbuild/images@7bd70d8

Go 1.21 is included in all currently supported distro versions.
It is required by new updates to some of our dependencies, including
osbuild/images.
Some depsolve-related error messages in osbuild/images changed.  Update
the expected error messages in our tests.
@achilleas-k achilleas-k merged commit a55bf9a into osbuild:main Jul 4, 2024
41 of 42 checks passed
@achilleas-k achilleas-k deleted the update-images branch July 4, 2024 17:01
schuellerf added a commit to schuellerf/osbuild-composer that referenced this pull request Jul 5, 2024
croissanne pushed a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants