Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/api: silent dump_db() #4276

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

achilleas-k
Copy link
Member

When cleaning up api tests, the build job results are dumped from the database to store in build-result.txt and are printed to the runner log at the same time. This makes it very difficult to read results as the database dump prints very long lines that flood the job log. The result isn't really readable (or useful) unless the file is downloaded separately.

Silence the tee command so that the file is created but no output is printed from the db dump.

See for example this job log which starts with the last line of the database dump. To see previous lines, you need to switch to the complete raw form.

When cleaning up api tests, the build job results are dumped from the
database to store in build-result.txt and are printed to the runner log
at the same time.  This makes it very difficult to read results as the
database dump prints very long lines that flood the job log.  The result
isn't really readable (or useful) unless the file is downloaded
separately.

Silence the `tee` command so that the file is created but no output is
printed from the db dump.
Copy link
Contributor

@jrusz jrusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense, it's saved into the ARTIFACTS folder so it will be available in S3 to look at.

Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! Thank you! 🎉

@thozza thozza enabled auto-merge (rebase) July 29, 2024 12:49
@thozza thozza merged commit 769b04b into osbuild:main Jul 29, 2024
42 checks passed
@achilleas-k achilleas-k deleted the test/api/silent-dumpdb branch July 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants