Openscap compliance facts (HMS-2836) #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
changed the title
croissanne
commented
Sep 5, 2024
| @@ -975,6 +975,12 @@ components: | |||
| required: | |||
| - profile_id | |||
| properties: | |||
| policy_id: | |||
There was a problem hiding this comment.
I'm unsure if this belongs here, could add a separate 'Compliance' customisation.
There was a problem hiding this comment.
Yeah this is a fair point. I don't have strong feelings though
croissanne
requested review from
kingsleyzissou
and removed request for
kingsleyzissou
croissanne
force-pushed
the
openscap-compliance-facts
branch
from
68a2f54
to
a75e205
Compare
Also adds the policy id to the blueprint, this doesn't have any effect on the openscap step, it just puts in place the rhsm fact so instances registered to insights will appear under that policy.
croissanne
force-pushed
the
openscap-compliance-facts
branch
from
a75e205
to
943d487
Compare
croissanne
force-pushed
the
openscap-compliance-facts
branch
from
943d487
to
87fadff
Compare
kingsleyzissou
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the policy id to the blueprint, this doesn't have any effect
on the openscap step, it just puts in place the rhsm fact so instances
registered to insights will appear under that policy.