internal/worker/client.go: refactor reading worker ID #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
requested changes
Sep 6, 2024
There was a problem hiding this comment.
LGTM, but the commit message isn't very clear, there are two mutexes in the worker client, and it's not calling to the mutex, it's reading the worker ID.
Can you change the commit message to something like:
internal/worker/client: or worker(client): + refactor reading worker ID
Adds a helper function to the worker client instead of redeclaring the same inline function everywhere.
Adds a helper function to the worker client instead of redeclaring the same inline function.
schuellerf
force-pushed
the
refactor-call-to-mutex
branch
from
5fb6ba5
to
aa75349
Compare
Thanks - the message was really bad :-/ |
croissanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just refactor the usage of the mutex to remove code duplication