Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable ostree-remount service checking since /sysroot is ro and /var rw already #4394

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mcattamoredhat
Copy link
Contributor

This pull request includes:

Since /sysroot is being mounted as ro and /var as rw, ostree-remount.service will not remount those mountpoints. The test is no longer necessary.
Thus, this PR suggests to delete the task as a workaround for the reported Jira edge-commit CS9 failure: ostree-remount.service fails to remount /sysroot and /var mountpoints

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

@mcattamoredhat mcattamoredhat force-pushed the disable-remount-check branch 2 times, most recently from 3c3b8ab to da54827 Compare October 3, 2024 10:07
@say-paul
Copy link
Member

say-paul commented Oct 3, 2024

LGTM

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the commit message with the same details you put in the github description? It would make it clear to people looking at the git log as to why this was changed.

@mcattamoredhat mcattamoredhat changed the title test: disable ostree-remount checks test: disable ostree-remount service checking since /sysroot is ro and /var rw already Oct 8, 2024
@supakeen supakeen merged commit 425583c into osbuild:main Oct 11, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants