-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement running db tests locally #4431
Implement running db tests locally #4431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think a compose file is a bit overkill. I don't see why we have to run two containers just to run the test, plus it's another container file to maintain for which we need to keep the go version up to date.
In the end running a single container is just a one liner. And I think it's reasonable to expect tern
to be installed on the host? After all it's kind of a development dependency here.
The idea is, that the setup is as similar to the github actions as possible, so installing a specific postgres version and a specific go version is not a one liner containerfile, I guess. |
1b0ec46
to
56b8cd8
Compare
Personally, I think the only way this will be actively maintained is if the github workflow actually calls the make target that you're adding here. I think the make target should just spin up a postgres container in case it's not running (the exact version doesn't matter imo, as long as it's maintained, we don't depend on a specific version of postgres) and do the test. The workflow should then just call the make target. Similar to what we do for |
56b8cd8
to
a746947
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, ig we should edit the comment though?
enables the option to run the DB tests locally that are executed in the github actions
It does not run the tests because of to the "-c" flag
Not needed for the test but just generates a useless warning
a746947
to
e4fb7ee
Compare
This PR implements
make db-tests
and extendsmake clean
The tests which are run locally until now used the
fsjobqueue
and the postgres DB tests were only run in github.For now this just implements running the tests. More improvements to the tests them selves will be handled in subsequent PRs.