Makefile: clean golangci-lint cache on make clean
#4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuellerf
force-pushed
the
clean-golangci-lint-cache
branch
from
900f613
to
29ce9eb
Compare
To speedup `make lint` we use a local cache. It seems that there is no sane way to check and just update the cache, so we'll just provide an option to wipe it. Using the cache does reduce the time of `make lint` from 1 minute 15sec to 1 sec on my PC. So for consecutive runs, the cache still makes sense.
schuellerf
force-pushed
the
clean-golangci-lint-cache
branch
from
29ce9eb
to
29a023a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #4435.
To speedup
make lintwe use a local cache.It seems that there is no sane way to check and just update the cache, so we'll just provide an option to wipe it.
Using the cache does reduce the time of
make lintfrom 1 minute 15sec to 1 sec on my PC. So for consecutive runs, the cache still makes sense.Thanks @mvo5 for the tests in #4435