Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't declare poly ring vars ahead of time #215

Closed
wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Member

Don't declare variables we only need later or even never.

@SoongNoonien or is there any reason why we should? If not, could you please apply the same changes to all of the tables?

Don't declare variables we only need later or even never
@SoongNoonien
Copy link
Member

We do need them for tensor products, scalar products and class coefficients. While we could stop declaring them we will need them eventually. For a proper fix we would need to redesign the whole system with the var_shifts.

@fingolfin
Copy link
Member Author

Of course we need them but why do we have to declare them before using them? The code should be able to generate these variables on the fly, that's the whole point of universal polynomial rings, isn't it?

@SoongNoonien
Copy link
Member

The code should be able to generate these variables on the fly, that's the whole point of universal polynomial rings, isn't it?

But the code depends on the order the variables are in. We need the universal polynomial features just for linear_combination where it is unknown how many variables will be needed.

@fingolfin
Copy link
Member Author

But the code depends on the order the variables are in.

Ahhh, OK. That sounds really unsafe to me. But OK, then that's how it is for now.

@fingolfin fingolfin closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants