-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/bb direct call #312
Draft
kalmarek
wants to merge
12
commits into
master
Choose a base branch
from
enh/bb_direct_call
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enh/bb direct call #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using Polymake
function BB_iterator(c)
N = polytope.dim(c)
@info "running bb using iterator over $N-dimensional polytope"
bb = Polymake.BeneathBeyond(c.POINTS, c.LINEALITY_SPACE, redundant=true, triangulation=true, iscone=true)
tr = GC.@preserve bb begin
for x in bb
@show length(Polymake.getTriangulation(bb.algo))
end
tr = Polymake.getTriangulation(bb.algo)
@show last(tr)
tr
end
@info "bb is done!"
return tr
end
function BB_direct_call(c)
N = polytope.dim(c)
@info "running bb using direct calls over $N-dimensional polytope"
bb = Polymake.BeneathBeyondAlgo{Polymake.Rational}()
Polymake.bb_initialize!(bb, c.POINTS, c.LINEALITY_SPACE)
for p in 0:6
@time Polymake.bb_add_point!(bb, p)
end
@show Polymake.getTriangulation(bb)
@time for p in 2:size(c.POINTS, 1)-1
Polymake.bb_add_point!(bb, p)
end
tr = Polymake.getTriangulation(bb)
@show last(tr)
@info "bb is done!"
return tr
end;
const rs = polytope.rand_sphere(4,30);
@info "running placing_triangulation"
t1 = polytope.placing_triangulation(rs.POINTS)
t2 = let rs = rs
@info "running bb using bb_compute! over $N-dimensional polytope"
bbalgo = Polymake.BeneathBeyondAlgo{Polymake.Rational}()
GC.@preserve bbalgo begin
Polymake.bb_compute!(bbalgo, rs.POINTS, rs.LINEALITY_SPACE)
Polymake.getTriangulation(bbalgo)
end
end
@assert t1 == t2
t3 = BB_direct_call(rs)
@assert t1 == t3
t4 = BB_iterator(rs)
@assert t1 == t4 occasionally (rather often?) crashes in different places (once I've seen this even in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.