Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Julia >= 1.3 #244

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Require Julia >= 1.3 #244

merged 1 commit into from
Jun 10, 2020

Conversation

fingolfin
Copy link
Member

... since we are now using a JLL package, which generally requires Julia >= 1.3

Closes #243

Two alternatives come to mind:

  1. it would be possible to insert code which can be used in Julia 1.0-1.2 to substitute for the JLLs (see WIP: Pkg Artifacts with legacy mode LoadFlint.jl#4)
  2. We could just accept that 4ti2 won't work in older Julia versions, and just disable any code (and tests) using it there.

That said, I think we should just merge this PR, it's the least work, and long term we will want to require the next Julia LTS anyway (right now it looks good for Julia 1.6 becoming that, but time will tell...)

... since we are now using a JLL package, which generally requires Julia >= 1.3
@fingolfin fingolfin requested a review from wbhart June 10, 2020 14:34
@wbhart
Copy link
Contributor

wbhart commented Jun 10, 2020

I don't really see why this works with 1.4. I thought semver would only allow things in the 1.3 series if you annotate it this way. But whatever, it seems to work.

I also thought the Julia people preferred Julia to have a range of supported versions, not just a lower limit. But maybe I got that mixed up too.

@wbhart wbhart merged commit 17247e8 into oscar-system:master Jun 10, 2020
@fingolfin
Copy link
Member Author

fingolfin commented Jun 10, 2020

@wbhart "1.3" is identical to "^1.3" and indicates the version range [1.3, 2). And writing it this way is
pretty much standard, in fact I don't know any Julia package doing it differently.

@fingolfin fingolfin deleted the mh/versions branch June 10, 2020 21:44
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singular no longer builds on Ubuntu with Julia-1.0.4
2 participants