Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: add compat for Statistics #713

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

benlorenz
Copy link
Member

Statistics is now an upgradeable stdlib on nightly, see JuliaLang/julia#46501.

This is causing the Aqua test to fail in PkgEval: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2023-10/01/Singular.primary.log

     Testing Running tests...
Singular [bcd08a7b-43d2-5ff7-b6d4-c458787f915c] does not declare a compat entry for the following deps:
1-element Vector{Base.PkgId}:
 Statistics [10745b16-79ce-11e8-11f9-7d13ad32a3b2]
Compat bounds: Test Failed at /home/pkgeval/.julia/packages/Aqua/dInrs/src/deps_compat.jl:21
  Expression: isempty(result)
   Evaluated: isempty(Base.PkgId[Statistics [10745b16-79ce-11e8-11f9-7d13ad32a3b2]])

Lets see if this works in the CI here.

The same compat was already added to the registry: https://github.com/JuliaRegistries/General/blob/master/S/Singular/Compat.toml#L268

this is now an upgradeable stdlib on nightly
@fingolfin fingolfin merged commit 0d979e4 into oscar-system:master Oct 2, 2023
14 checks passed
@benlorenz benlorenz deleted the bl/statscompat branch October 2, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants