-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Accounts Service #3
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
module github.com/oschwald/go-pivotaltracker | ||
|
||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package pivotal | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
"time" | ||
) | ||
|
||
type Account struct { | ||
CreatedAt *time.Time `json:"created_at"` | ||
ID int `json:"id"` | ||
Kind string `json:"kind"` | ||
Name string `json:"name"` | ||
Plan string `json:"plan"` | ||
Status string `json:"status"` | ||
UpdatedAt *time.Time `json:"updated_at"` | ||
} | ||
|
||
type AccountsService struct { | ||
client *Client | ||
} | ||
|
||
func newAccountsService(client *Client) *AccountsService { | ||
return &AccountsService{client} | ||
} | ||
|
||
func (service *AccountsService) Get(accountID int) (*Account, *http.Response, error) { | ||
u := fmt.Sprintf("accounts/%d", accountID) | ||
req, err := service.client.NewRequest("GET", u, nil) | ||
if err != nil { | ||
return nil, nil, err | ||
} | ||
|
||
var account Account | ||
resp, err := service.client.Do(req, &account) | ||
if err != nil { | ||
return nil, resp, err | ||
} | ||
|
||
return &account, resp, nil | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ import ( | |
"io" | ||
"net/http" | ||
"net/url" | ||
"strings" | ||
"time" | ||
) | ||
|
||
|
@@ -59,6 +60,7 @@ type Story struct { | |
AcceptedAt *time.Time `json:"accepted_at,omitempty"` | ||
Deadline *time.Time `json:"deadline,omitempty"` | ||
RequestedByID int `json:"requested_by_id,omitempty"` | ||
RequestedBy Person `json:"requested_by,omitempty"` | ||
OwnerIDs []int `json:"owner_ids,omitempty"` | ||
LabelIDs []int `json:"label_ids,omitempty"` | ||
Labels []*Label `json:"labels,omitempty"` | ||
|
@@ -198,7 +200,7 @@ func newStoryService(client *Client) *StoryService { | |
// is not always sorted when using a filter, this approach is required to get | ||
// the right data. Not sure whether this is a bug or a feature. | ||
func (service *StoryService) List(projectID int, filter string) ([]*Story, error) { | ||
reqFunc := newStoriesRequestFunc(service.client, projectID, filter) | ||
reqFunc := newStoriesRequestFunc(service.client, projectID, filter, nil) | ||
cursor, err := newCursor(service.client, reqFunc, 0) | ||
if err != nil { | ||
return nil, err | ||
|
@@ -211,17 +213,66 @@ func (service *StoryService) List(projectID int, filter string) ([]*Story, error | |
return stories, nil | ||
} | ||
|
||
func newStoriesRequestFunc(client *Client, projectID int, filter string) func() *http.Request { | ||
func newStoriesRequestFunc(client *Client, projectID int, filter string, fields []string) func() *http.Request { | ||
return func() *http.Request { | ||
u := fmt.Sprintf("projects/%v/stories", projectID) | ||
if filter != "" { | ||
u += "?filter=" + url.QueryEscape(filter) | ||
if len(fields) == 0 { | ||
fields = DefaultFields | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems redundant given that I do wonder if not including the param would be less surprising if there are no fields passed, but I am fine with it as is given that we are only using this internally. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I agree. Thank you, I have removed it. 👍 |
||
u += "&fields=" + url.QueryEscape(fieldsToQuery(fields)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some info about this, |
||
} | ||
req, _ := client.NewRequest("GET", u, nil) | ||
return req | ||
} | ||
} | ||
|
||
var DefaultFields = []string{ | ||
"id", | ||
"project_id", | ||
"name", | ||
"description", | ||
"story_type", | ||
"current_state", | ||
"estimate", | ||
"accepted_at", | ||
"deadline", | ||
"requested_by_id", | ||
"owner_ids", | ||
"task_ids", | ||
"follower_ids", | ||
"created_at", | ||
"updated_at", | ||
"url", | ||
"kind", | ||
} | ||
|
||
// function returns the fields in a query string format. | ||
func fieldsToQuery(fields []string) string { | ||
if len(fields) == 0 { | ||
fields = DefaultFields | ||
} | ||
return strings.Join(fields, ",") | ||
} | ||
|
||
// ListOnlyFields returns all the fields of the stories matching the filter given. | ||
// Example: fields = []string{"id", "name", "description"} | ||
// Having nil or empty fields will return all the fields. | ||
func (service *StoryService) ListWithFields(projectID int, filter string, fields []string) ([]*Story, error) { | ||
reqFunc := newStoriesRequestFunc(service.client, projectID, filter, fields) | ||
cursor, err := newCursor(service.client, reqFunc, 0) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
var stories []*Story | ||
if err := cursor.all(&stories); err != nil { | ||
return nil, err | ||
} | ||
return stories, nil | ||
} | ||
|
||
// StoryCursor is used to implement the iterator pattern. | ||
type StoryCursor struct { | ||
*cursor | ||
|
@@ -250,7 +301,7 @@ func (c *StoryCursor) Next() (s *Story, err error) { | |
// Iterate returns a cursor that can be used to iterate over the stories specified | ||
// by the filter. More stories are fetched on demand as needed. | ||
func (service *StoryService) Iterate(projectID int, filter string) (c *StoryCursor, err error) { | ||
reqFunc := newStoriesRequestFunc(service.client, projectID, filter) | ||
reqFunc := newStoriesRequestFunc(service.client, projectID, filter, nil) | ||
cursor, err := newCursor(service.client, reqFunc, PageLimit) | ||
if err != nil { | ||
return nil, err | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run
go mod tidy
. There should be a Go version number.