Disable Datadog

[brettcurtis]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The recent update streamlines integration and configuration management across different environments. Notably, it adjusts Terraform configurations to refine how resources are provisioned and monitored. The modifications include removing a specific billing parameter from Terraform plans across various environments and toggling a monitoring feature in the sandbox environment. Additionally, a default value for a previously sensitive billing account variable has been established, enhancing clarity and control over billing management.

Changes

Files	Summary
.github/workflows/.../non-production.yml, .github/workflows/.../production.yml, .github/workflows/.../sandbox.yml	Removed -var=billing_account parameter from terraform_plan_secret_args, kept Datadog API keys parameters.
global/tfvars/sandbox.tfvars	Changed enable_datadog flag from true to false.
global/variables.tf	Changed billing_account variable's attribute from sensitive to default, set value to "01C550-A2C86B-B8F16B".

---

Recent Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f4330e and 07acaa2.

Files selected for processing (5)

• .github/workflows/non-production.yml (1 hunks)
• .github/workflows/production.yml (1 hunks)
• .github/workflows/sandbox.yml (1 hunks)
• global/tfvars/sandbox.tfvars (1 hunks)
• global/variables.tf (1 hunks)

Additional comments not posted (5)

global/tfvars/sandbox.tfvars (1)

2-2: Change aligns with the objective to disable Datadog. Ensure all dependent configurations are adjusted accordingly.

global/variables.tf (1)

7-7: Change to billing_account default value noted. Ensure this does not inadvertently affect other configurations or billing processes.

.github/workflows/sandbox.yml (1)

Line range hint 31-31: Removal of -var=billing_account parameter aligns with PR objectives. Verify the workflow's functionality post-change.

.github/workflows/non-production.yml (1)

Line range hint 31-31: Consistent with PR objectives, the removal of -var=billing_account parameter is noted. Ensure workflow functionality remains intact.

.github/workflows/production.yml (1)

Line range hint 31-31: Removal of -var=billing_account parameter is consistent across workflows and aligns with PR objectives. Verify production workflow functionality post-change.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[infracost]

💰 Infracost report

Monthly cost will decrease by $25 📉

Changed project	Baseline cost	Usage cost*	Total change	New monthly cost
global-sandbox	+$0	-$25	-$25 (-83%)	$5

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

Cost details (includes details of unsupported resources)

Key: * usage cost, ~ changed, + added, - removed

──────────────────────────────────
Project: global-sandbox
Module path: global

- module.datadog[0].google_logging_project_sink.integration
  -$5

    - Logging data
      -$5, -10 GB*

- module.datadog[0].google_pubsub_topic.integration
  -$5

    - Message ingestion data
      -$5, -0.125 TiB*

- module.datadog[0].google_pubsub_subscription.integration
  -$15

    - Message delivery data
      -$5, -0.125 TiB*

    - Retained acknowledged message storage
      -$5, -18 GiB*

    - Snapshot message backlog storage
      -$5, -18 GiB*

Monthly cost change for global-sandbox (Module path: global)
Amount:  -$25 ($30 → $5)
Percent: -83%

──────────────────────────────────
Key: * usage cost, ~ changed, + added, - removed

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

74 cloud resources were detected:
∙ 2 were estimated
∙ 66 were free
∙ 6 are not supported yet, rerun with --show-skipped to see details

Infracost estimate: Monthly cost will decrease by $25 ↓
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Changed project                                    ┃ Baseline cost ┃ Usage cost ┃ Total change ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ global-sandbox                                     ┃           +$0 ┃       -$25 ┃  -$25 (-83%) ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

Governance checks

🟢 54 passed

52 FinOps policies, 1 Tagging policy, and 1 Guardrail passed.

_{View report in Infracost Cloud. This comment will be updated when code changes.}