startup.sh: Ensure SCHEMAS is sorted #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`find` doesn't sort the output, but if you don't sort it and two schema files are dependent on each other (schema 2 uses an attribute defined in schema 1) the startup of the container will fail. By sorting it you can know/rely on asciibetical sorting to ensure the schema files get included in the right order.
|
I just ran into this trying to import the Apple OpenDirectory schemas, which need some old Samba2 schema, but I could not get it to work until I manually combined the files in the right order, but that is not ideal. |
|
@n9yty Hah, that's exactly my problem too. |
|
Merged in 1.2.0 |
|
No worries, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finddoesn't sort the output, but if you don't sort it and two schema files are dependent on each other (schema 2 uses an attribute defined in schema 1) the startup of the container will fail iffinddoesn't happen to return in the order needed. By sorting it you can know/rely on asciibetical sorting to ensure the schema files get included in the right order.Also, this isn't needed if instead of
findyou usefor f in /path/to/*.schemaas the glob already returns in asciibetical order. Makes for one less call to a binary too.