Only listen on ldapi:/// during bootstrapping #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, slapd listens on ldap:/// and ldapi:/// during bootstrapping, which means that external connections to the container can get accepted before the bootstrapping is complete. This causes issues when using custom LDIF files, which may not have fully processed by the time an external query is made. This PR changes the startup.sh script to make slapd only listen on ldapi:/// (effectively local-only access) during the bootstrapping stage. This should also help when using Kubernetes readiness probes, which may get prematurely triggered during the bootstrap stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, slapd listens on ldap:/// and ldapi:/// during
bootstrapping, which means that external connections to the
container can get accepted before the bootstrapping is complete.
This causes issues when using custom LDIF files, which may not
have fully processed by the time an external query is made.
This PR changes the startup.sh script to make slapd only listen on
ldapi:/// (effectively local-only access) during the bootstrapping
stage. This should also help when using Kubernetes readiness
probes, which may get prematurely triggered during the bootstrap
stage when the container should not be accepting connections.