Updated validation in RegisterProduct factory

oskardudycz · May 24, 2021 · 1aeddc6 · 1aeddc6
1 parent 10c4f3f
commit 1aeddc6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sample/Warehouse/Warehouse/Products/RegisteringProduct/RegisterProduct.cs b/Sample/Warehouse/Warehouse/Products/RegisteringProduct/RegisterProduct.cs
@@ -57,8 +57,10 @@ private RegisterProduct(Guid productId, SKU sku, string name, string? descriptio
 
         public static RegisterProduct Create(Guid? id, string? sku, string? name, string? description)
         {
-            if (!id.HasValue) throw new ArgumentNullException(nameof(id));
-            if (name == null) throw new ArgumentNullException(nameof(name));
+            if (!id.HasValue || id == Guid.Empty) throw new ArgumentOutOfRangeException(nameof(id));
+            if (string.IsNullOrEmpty(sku)) throw new ArgumentOutOfRangeException(nameof(sku));
+            if (string.IsNullOrEmpty(name)) throw new ArgumentOutOfRangeException(nameof(name));
+            if (description is "") throw new ArgumentOutOfRangeException(nameof(name));
 
             return new RegisterProduct(id.Value, SKU.Create(sku), name, description);
         }