-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example of MapCommand for extreme endpoints handling #43
Open
oskardudycz
wants to merge
1
commit into
main
Choose a base branch
from
extreme_cqrs_with_net5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
extreme_cqrs_with_net5
branch
3 times, most recently
from
May 17, 2021 08:57
69fef36
to
fcb1f4c
Compare
oskardudycz
force-pushed
the
cqrs_with_net5
branch
2 times, most recently
from
May 17, 2021 10:24
baf083c
to
5b83868
Compare
oskardudycz
force-pushed
the
extreme_cqrs_with_net5
branch
from
May 17, 2021 10:27
fcb1f4c
to
68d40cf
Compare
oskardudycz
force-pushed
the
cqrs_with_net5
branch
2 times, most recently
from
May 17, 2021 15:11
9cb8be6
to
54fdc6b
Compare
oskardudycz
force-pushed
the
extreme_cqrs_with_net5
branch
6 times, most recently
from
May 17, 2021 19:24
bb5ca4d
to
a1cea48
Compare
oskardudycz
force-pushed
the
cqrs_with_net5
branch
from
May 17, 2021 19:33
6b07daf
to
9c348dc
Compare
oskardudycz
force-pushed
the
extreme_cqrs_with_net5
branch
2 times, most recently
from
May 18, 2021 06:37
008724c
to
4a53753
Compare
oskardudycz
force-pushed
the
extreme_cqrs_with_net5
branch
2 times, most recently
from
May 24, 2021 07:20
39b2d79
to
12b547f
Compare
oskardudycz
force-pushed
the
extreme_cqrs_with_net5
branch
from
September 8, 2021 07:24
12b547f
to
0af3b20
Compare
oskardudycz
force-pushed
the
main
branch
18 times, most recently
from
October 3, 2021 17:48
3983fb3
to
241e8be
Compare
oskardudycz
force-pushed
the
main
branch
3 times, most recently
from
December 9, 2021 08:28
cbbe4c2
to
70b393e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the comment from @adrianiftode in #41.
I added an example of how to not need to define custom endpoints but have shortened extension method that will:
The main endpoint mapping function looks as follows:
I had to add command result to the command handler.
then you could register is as:
Still, I'm not yet convinced that's the better option. By that, you're losing:
I think that this could work if you're just doing the basic mapping for this particular case, and if you're not, you can fall back to the custom one.
I need to sleep through that :D I might add it into GoldenEye.