Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix conda activate inside the smoke test #226

Merged
merged 10 commits into from
Feb 29, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Feb 29, 2024

Pull Request description

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab
Copy link
Member Author

xmnlab commented Feb 29, 2024

@Saransh-cpp @Anavelyz @YurelyCamacho
I hope that with this the tests will be working properly again.
I will comment out the PR title check in another PR .. until it is working again
I am merging this PR now, because we need fix this on the main branch as soon as possible.
feel free to drop here any comment and I can work on that as a follow up

@xmnlab xmnlab merged commit 2831f1e into osl-incubator:main Feb 29, 2024
10 of 11 checks passed
@xmnlab xmnlab deleted the fix-smoke-tests branch February 29, 2024 02:14
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant