-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doc-template): adding options for documentation themes #292
Conversation
src/scicookie/cookiecutter.json
Outdated
@@ -19,6 +19,14 @@ | |||
"command_line_interface": ["None", "Click", "Argparse"], | |||
"documentation_engine": ["mkdocs", "sphinx", "jupyter-book", "quarto"], | |||
"documentation_url": "{{ cookiecutter.project_url }}", | |||
"mkdocs_theme": ["Material", "Cinder", "Mkdocs", "Readthedocs"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the first option should be "Default" for all the four variables about themes (mkdocs, sphinx and jupyter book)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the profiles/osl.yaml
we should have by default (and visible: False) the documentation engine mkdocs, and the theme material .. osl profile will be very opinionated .. that will be the default structure that we will use for all of our projects.
7803130
to
ec8a5e9
Compare
@Anavelyz ... thanks for working on that. testing it with sphinx, the command makim.preview failed:
could you check that please? I didn't test the command makim docs.preview command with jupyter-book .. thanks! |
90e0dc5
to
acda7de
Compare
I was checking and the error is because pandoc is not installed correctly, in pip there is an outdated version. In the documentation they recommend to use conda, I tried it locally and the error disappears... |
f73cd80
to
77311fa
Compare
src/scicookie/{{cookiecutter.project_slug}}/docs-quarto/_quarto.yml
Outdated
Show resolved
Hide resolved
src/scicookie/{{cookiecutter.project_slug}}/docs/contributing.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Anavelyz , thanks for working on that.
in general that looks really good, thanks!
I just add two comments here.
I think that it would be nice if we standardize the value for the options, to be always without space, with dash instead, and all letters in lowercase ...
in this specific case, it would be missing just the step to convert the values to lowercase, for example, PyData
-> pydata
.
and of course, just in the template variable ... not in the documentation
38957b7
to
7246b41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on that @Anavelyz .
I saw that a few $
was removed ... I think that probably it would be better to keep that ... but for now I will merge this PR ... so we can discuss and fix that later.
thanks! good job here! appreciate that.
🎉 This issue has been resolved in version 0.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
Adding options for documentation themes:
Fixes #108
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
main
branch