Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add busways #477

Merged
merged 30 commits into from
Apr 7, 2023
Merged

Add busways #477

merged 30 commits into from
Apr 7, 2023

Conversation

claysmalley
Copy link
Member

Fixes #308.

Since it looks like purple is going to be the color for public transit, infrastructure dedicated to public transit might as well be purple too. This may influence design decisions about railways dedicated to public transport (subway, funicular, etc.) as #476 progresses.

Screenshot from 2022-07-07 21-04-50 Screenshot from 2022-07-07 21-05-40

@claysmalley
Copy link
Member Author

After some discussion on Slack, I think busways may need lowlighting instead of highlighting. Dull gray works pretty well, and helps indicate that these serve a special purpose but are not accessible for general traffic.

Screenshot from 2022-07-08 09-49-10 Screenshot from 2022-07-08 09-49-30

Bonus screenshots with railroads from #476:

Screenshot from 2022-07-08 09-59-34 Screenshot from 2022-07-08 09-59-11

@ZeLonewolf
Copy link
Member

At high zoom, the busway is gray cased in black. Is it our intent that non-drivable roads like this have a common fill color? Just trying to think through if there's other feature classes that fit the mold here.

@claysmalley
Copy link
Member Author

Pedestrian streets come to mind: #185

@ZeLonewolf
Copy link
Member

ZeLonewolf commented Jul 9, 2022

Exploring a subtle purple at z15+. What do we think?

image

image

@1ec5
Copy link
Member

1ec5 commented Jul 9, 2022

Do any busways run near county lines? The faint purple might be too similar to the border highlight for admin_level=6.

@claysmalley
Copy link
Member Author

Here's a busway in the Philadelphia suburbs that runs close to a county line: (localhost link)

@ZeLonewolf
Copy link
Member

That's a weird example because the road sits on top of the county line, but this is what it looks like zoomed way in:

image

@ZeLonewolf
Copy link
Member

Another example, localhost link

image

@ZeLonewolf
Copy link
Member

Relaying @claysmalley comments in #476:

If busways are rendered in purple in #477, it may set a precedent for public transit railways (subway, tram, funicular, etc.) to be purple as well.

I agree that what we're searching for here is the general case for how we want that collection of features to render.

@claysmalley
Copy link
Member Author

I'm considering a more lavender hue to distinguish from taxiways better. I'm still indecisive on whether busways should be highlighted with a particular color on the default map, or lowlighted with a dull gray.

Amsterdam Schiphol Airport:
Screenshot from 2022-07-10 19-12-43
Screenshot from 2022-07-10 19-13-04

Almere, Netherlands:
Screenshot from 2022-07-10 19-13-25
Screenshot from 2022-07-10 19-14-07

@1ec5
Copy link
Member

1ec5 commented Jul 11, 2022

The “highlighting” in #477 (comment) reminds me of how city street maps highlight road routes in highlighter/pastel colors while keeping the width realistic. This will be an important tool at high zoom levels once we implement realistic road widths (#372 #486), so I’m a bit hesitant about introducing road fill colors for other purposes such as distinguishing modes of transportation. What if we go back to the grayed-out fill but change the casing color?

@ZeLonewolf
Copy link
Member

Thinking about this more, should we treat a busway like a no-access service road?

@ZeLonewolf
Copy link
Member

Would it make sense to come up with a design scheme for roads tagged access=private and similar, and then unify that with busways?

@claysmalley
Copy link
Member Author

claysmalley commented Jul 12, 2022

I think so. Colorful busways may be appropriate for a future enhancement that enables switchable layers (#25), where we may want to highlight busways on a public transit map. But we're building the default general-purpose map first, and busways should probably have a similar treatment to other private-access roads.

@claysmalley claysmalley marked this pull request as draft September 1, 2022 01:06
@ZeLonewolf
Copy link
Member

Could this be as simple as "whatever service roads are tagged, but purple instead of black casing"?

@ZeLonewolf
Copy link
Member

Also note that a legend entry is now needed.

@claysmalley
Copy link
Member Author

I don't think it's clear enough from casing color alone that this is not a legally driveable road. We'll need to decide how to display private-access roads before we can fit busways into the picture.

Screenshot from 2023-01-11 12-37-24

@wmisener wmisener mentioned this pull request Feb 2, 2023
@1ec5
Copy link
Member

1ec5 commented Feb 16, 2023

I agree that what we're searching for here is the general case for how we want that collection of features to render.

Frankly, I don’t think it’s necessary to make all public transportation infrastructure the same color, as if all public transportation is a thematic overlay apart from the basemap. Public transportation is such a diverse range of features. Two users may not even agree whether air or rail transportation counts as public transportation, based on what’s available in their respective areas, so I don’t think we can count on them to intuit the relationship based on a color alone.

I don't think it's clear enough from casing color alone that this is not a legally driveable road. We'll need to decide how to display private-access roads before we can fit busways into the picture.

I think it should be the other way around: we’re already showing plenty of restricted-access roads undifferentiated from public-access roads, so adding a few that happen to be busways doesn’t exacerbate the problem very much.

Let’s figure out a general restricted-access treatment separately in #679. In the meantime, a busway shares more in common with a public-access service road than it does with vacant land, which is how we’re depicting busways currently. If we’re concerned about confusion with drivable roads, we could have the label simply say “Busway” instead of the road name, though many will already have “Busway” in the name.

@claysmalley
Copy link
Member Author

claysmalley commented Apr 6, 2023

Bringing back colorful busways, this time in a desaturated mauve to match the public transit icons added in #845.

Screenshot from 2023-04-06 10-55-49

Screenshot from 2023-04-06 10-54-19

Screenshot from 2023-04-06 18-27-52

@claysmalley claysmalley marked this pull request as ready for review April 6, 2023 14:58
@claysmalley
Copy link
Member Author

claysmalley commented Apr 6, 2023

Guided busways are included now, styled identically.

Screenshot from 2023-04-06 18-29-06

@claysmalley claysmalley linked an issue Apr 6, 2023 that may be closed by this pull request
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough to add to the map at this point.

We could probably argue about the exact width and level of prominence but scrolling around, it doesn't seem like it's overpowering, nor does it crowd out other features.

image

@claysmalley claysmalley merged commit 091a4d8 into main Apr 7, 2023
@claysmalley claysmalley deleted the clay-busway branch April 7, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request highway-lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render guided busways Render busways
3 participants