chore(app/upgrades): set app version correctly for v11 #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Jul 15, 2022
Comment on lines
+23
to
+28
| // Although the app version was already set during the v9 upgrade, our v10 was a fork. | ||
| // As a result, the upgrade handler was not executed to increment the app version. | ||
| // This change helps to correctly set the app version for v11. | ||
| if err := keepers.UpgradeKeeper.SetAppVersion(ctx, preUpgradeAppVersion); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Do we have to do this manually every upgrade? Or is this just one-off code that we only have to do once? Also why does the API take in pre upgrade version, not post?
There was a problem hiding this comment.
Do we have to do this manually every upgrade?
No, we need to do this now because the last release was a fork.
Also why does the API take in pre upgrade version, not post?
This is because this logic is run before the upgrade handler logic that increases this version by 1
ValarDragon
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1805
What is the purpose of the change
Although the app version was already set during the v9 upgrade, our v10 was a fork.
As a result, the upgrade handler was not executed to increment the app version.
This change helps to correctly set the app version for v11.
Testing and Verifying
This change can be verified by e2e upgrade tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no