Include version information in CMake and the program #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake files should be installed in the same lib directory as the main library for consistency. Also, this generates a version file to allow CMake to detect the version when searching for the library.
These defines allow software that use QDLDL to get its version inside the code.
|
|
|
Ping @goulart-paul or @bstellato. Either of you free to take a look at this? |
goulart-paul
approved these changes
Sep 16, 2020
|
Apologies for delay. It seems good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds version information to the generated CMake files and also a new header that contains the version string (as three parts). This allows software using the CMake find mechanism to know the version of the library and ensure it has the correct version. The header also allows the consuming programs to find the version of the library they are linked against.
An additional change made in this PR is to ensure the CMake find files are installed in the same directory as the library (e.g. lib64 if desired).
Fixes #32