Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Cmake options to have QDLDL prefix for namespacing #45

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Rename Cmake options to have QDLDL prefix for namespacing #45

merged 2 commits into from
Jun 20, 2022

Conversation

imciner2
Copy link
Member

This renames the CMake options to have QDLDL_ at the beginning, and removes the D prefix.

This was mentioned in a comment in PR #38.

@coveralls
Copy link

coveralls commented Apr 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2529076840

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1319969485: 0.0%
Covered Lines: 87
Relevant Lines: 87
💛 - Coveralls

bstellato
bstellato reviewed Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@bstellato bstellato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Just a minor thing. Could you please fix also the README.md to have the same prefixes in the "Custom types for integer, floats and booleans" section?

@imciner2
Copy link
Member Author

Fixed, and I also added the new options for controlling library products to the readme as well.

@bstellato bstellato self-requested a review June 20, 2022 13:05
@imciner2 imciner2 merged commit bc09f4c into master Jun 20, 2022
@imciner2 imciner2 deleted the im/cmakeoption branch June 20, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstellato bstellato bstellato approved these changes

@gbanjac gbanjac Awaiting requested review from gbanjac

@vineetbansal vineetbansal Awaiting requested review from vineetbansal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imciner2 @coveralls @bstellato