Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return after check/dump requests in init #6334

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Return after check/dump requests in init #6334

merged 1 commit into from
Mar 29, 2020

Conversation

theopolis
Copy link
Member

@theopolis theopolis commented Mar 27, 2020 •
edited
Loading

It is not enough to just requestShutdown, the ::start logic should also return early. This allows the binary to exit from main normally.

Fixes #6290, #6329.

@theopolis theopolis mentioned this pull request Mar 28, 2020
Merged
zwass
zwass approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@theopolis theopolis merged commit 46a46da into osquery:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwass zwass zwass approved these changes

Assignees
No one assigned
Labels
bug configuration database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4.2.0] config_check not exiting
2 participants
@theopolis @zwass