detangle: Move osquery shutdown logic outside of Initializer #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to have less inter-dependency within osquery components. This is the first of several changes that take small steps towards a simpler dependency graph. Later we can revisit the directory structure to see if we can convey what components are intended to be widely used and what components are specialized.
theopolis
force-pushed
the
detangle_series
branch
from
9222a29
to
5c24bc5
Compare
|
theopolis
force-pushed
the
detangle_series
branch
from
c5981aa
to
9606071
Compare
theopolis
force-pushed
the
detangle_series
branch
from
e626a28
to
1f3e2f2
Compare
5 tasks
theopolis
force-pushed
the
detangle_series
branch
from
c4b6c46
to
29ef8fd
Compare
theopolis
added
the
ready for review
There was a problem hiding this comment.
I looked over this (up to 29ef8fd), but I don't feel super comfortable with this part of the code. From what I can tell, it looks cleaner. I don't know if anyone else will take a look, but I can thumb this if no one else steps up
| * @param retcode the request return code for the process. | ||
| * @param system_log A log line to write to the system's log. | ||
| */ | ||
| void requestShutdown(int retcode, const std::string& system_log); |
There was a problem hiding this comment.
Do you think it makes sense to name this forceShutdown instead of just having the extra system_log argument?
There was a problem hiding this comment.
Maybe, but for this PR the thesis is detangling. We can refactor/rename things as separate as separate thesis later.
directionless
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to have less inter-dependency within osquery components.
This is the first of several changes that take small steps towards a
simpler dependency graph.
Later we can revisit the directory structure to see if we can convey
what components are intended to be widely used and what components
are specialized.
See #5990.