bug: Set thread names correctly on macOS and Linux #6627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up @Breakwell we might have a problem with the Windows sccache. I am unsure why the Windows CI failed here? |
Taking a quick look I didn't update the submodule cache to have unique key for the build job: https://github.com/osquery/osquery/blob/master/azure-pipelines.yml#L314 so it's just "Windows" I guess this would fall with the pattern of the libradkafka failing (it's a submodule) I'll raise a PR with a change to making it unique to the architecture: |
|
@Breakwell submodules are the same, doesn't matter if it's Windows 32 or 64, it's just a "git clone". |
theopolis
force-pushed
the
correct_thread_names
branch
from
d551ce2
to
e80cd8f
Compare
alessandrogario
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread names are limited to 16 characters include the ending
\0.