Secured protected virtual processes #7121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theopolis
requested changes
May 22, 2021
specs/processes.table
Outdated
| @@ -32,6 +32,9 @@ schema([ | |||
| ]) | |||
| extended_schema(WINDOWS, [ | |||
| Column("is_elevated_token", INTEGER, "Process uses elevated token yes=1, no=0"), | |||
| Column("is_secure_process", INTEGER, "Process is secure (IUM) yes=1, no=0"), | |||
There was a problem hiding this comment.
Nitpick and for general consistency I prefer if we avoid the is_ prefix for column names. This is because the column type implies the verb. Could we name this secure_process, etc?
We can change the is_elevated_token to just elevated_token as well?
There was a problem hiding this comment.
I was trying to be consistent following is_elevated_token 😄
I've changed them all as suggested now.
theopolis
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find processes that are secured (IUM), protected or virtual on Windows #7120