Replace WmiRequest constructor with static factory method #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change all the relevant calling sites to check for errors and do something sensible in that case.
mike-myers-tob
added
Windows
bug
ready for review
Also fix a couple typos.
|
Can @theopolis or @muffins review this one? I've already reviewed, but we were looking for a Windows person outside ToB to approve for merge |
|
Per the last office hours, this PR has been reviewed, and we will self-approve (I just need a hand from @Smjert for that) |
Smjert
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change all the relevant calling sites to check for errors and do something sensible in that case.
Fixes #7448.