Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop shortcut_files table #7547

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Drop shortcut_files table #7547

merged 1 commit into from
Apr 5, 2022

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Apr 5, 2022

Fixes #7545

@Smjert Smjert added virtual tables Windows deprecation Relating to function deprecation labels Apr 5, 2022
@Smjert Smjert requested review from a team as code owners April 5, 2022 13:44
@alessandrogario alessandrogario linked an issue Apr 5, 2022 that may be closed by this pull request
Exception while executing table shortcut_files: invalid string position #7380
Closed
mike-myers-tob
mike-myers-tob approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@mike-myers-tob mike-myers-tob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nothing added here just code removed: spec file, table implementation, tests, and CMake entries. There is no other documentation that mentions the table.

Another issue that should be closed by this PR:

#7380

@mike-myers-tob mike-myers-tob merged commit d81b8e4 into osquery:master Apr 5, 2022
alessandrogario pushed a commit to trailofbits/osquery that referenced this pull request Apr 5, 2022
@Smjert @alessandrogario
Drop shortcut_files table (osquery#7547)
c7703ba
@Smjert Smjert deleted the stefano/hardening/drop-shortcut-files branch April 5, 2022 20:20
aikuchin pushed a commit to aikuchin/osquery that referenced this pull request Jul 11, 2023
@mogrein
Merge pull request osquery#24 in CLOUD/osquery from sync/osquery-5.2.…
9b71df7 
…3 to master

* commit '35edba4e8627f883dc6394f60a7fff60a5a39353':
  libs: Update OpenSSL from version 1.1.1l to 1.1.1n (osquery#7506)
  Drop shortcut_files table (osquery#7547)
  Drop the ssdeep library and remove its hash support  (osquery#7525)
  libs: Update zlib from v1.2.11 to v1.2.12 (osquery#7548)
  Remove libelfin and elf parsing tables (osquery#7524)
  Update librpm to 4.17.0 (osquery#7529)
  libs: Update expat from version 2.2.10 to 2.4.7 (osquery#7526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharvilshah sharvilshah sharvilshah approved these changes

@lhmzhou lhmzhou lhmzhou approved these changes

@mike-myers-tob mike-myers-tob mike-myers-tob approved these changes

Assignees
No one assigned
Labels
deprecation Relating to function deprecation virtual tables Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate table: shortcut_files Exception while executing table shortcut_files: invalid string position
4 participants
@Smjert @sharvilshah @lhmzhou @mike-myers-tob