Fix permissions on opening pipes for reading in pipes table

[ExceptionalHandler]

This is in response to the #7809

Fixing the sharing mode parameter of CreateFileW API in genPipes() to open pipes in sharing mode, so that other processes can have read/write/delete access to the pipes when osquery's handles to those pipes are still open.

[mike-myers-tob]

Hi, I've reviewed this and agree with the issue, and thank you for your PR. It is definitely important for osquery not to cause other processes to fail while trying to access pipes just because osquery is enumerating them at that instant.

I don't have approval rights, but I would say it LGTM.

Just one comment, if we are allowing other processes to delete the pipe while we are looking at it (FILE_SHARE_DELETE), this may cause rows in the table where one or more fields get set to -1. The alternative is to prevent pipe deletion by not allowing FILE_SHARE_DELETE but this could hypothetically interfere with another process expecting pipe deletion to succeed.

[Smjert]

Closing and reopening for the CI to pick up the fix in master.

[Smjert]

Just one comment, if we are allowing other processes to delete the pipe while we are looking at it (FILE_SHARE_DELETE), this may cause rows in the table where one or more fields get set to -1. The alternative is to prevent pipe deletion by not allowing FILE_SHARE_DELETE but this could hypothetically interfere with another process expecting pipe deletion to succeed.

Yeah I would say that if osquery can in any way make an API call fail due to its inspection, that's a no go.