Migrate remaining Garden formulae to gz #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chapulina
commented
Jun 24, 2022
chapulina
commented
- Part of CMake project names from ignition to gz gazebo-tooling/release-tools#718
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
methylDragon
approved these changes
Jun 24, 2022
17 tasks
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
scpeters
reviewed
Jun 28, 2022
| @@ -47,7 +47,7 @@ def install | |||
| end | |||
|
|
|||
| test do | |||
| yaml_file = share/"ignition/ignition-garden/gazebodistro/collection-garden.yaml" | |||
| yaml_file = share/"gz/gz-garden/gazebodistro/collection-garden.yaml" | |||
There was a problem hiding this comment.
I think these install paths are not updated yet
vcs validate: error: argument --input: can't open
'/usr/local/Cellar/ignition-garden/0.999.999~0~20220414/share/gz/gz-garden/gazebodistro/collection-garden.yaml':
[Errno 2] No such file or directory:
'/usr/local/Cellar/ignition-garden/0.999.999~0~20220414/share/gz/gz-garden/gazebodistro/collection-garden.yaml'
There was a problem hiding this comment.
Yeah we haven't migrated IGN_DATA_INSTALL_DIR yet. This was future-proofing. I understood no bottles were being built yet.
There was a problem hiding this comment.
the garden formula is a special case; we have a nightly job to build that formula and run its test. I had forgotten about this when saying that tests were only used when building bottles. I'll submit a small PR to fix this formula only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.