-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining Garden formulae to gz #1946
Conversation
chapulina
commented
Jun 24, 2022
- Part of CMake project names from ignition to gz gazebo-tooling/release-tools#718
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@@ -47,7 +47,7 @@ def install | |||
end | |||
|
|||
test do | |||
yaml_file = share/"ignition/ignition-garden/gazebodistro/collection-garden.yaml" | |||
yaml_file = share/"gz/gz-garden/gazebodistro/collection-garden.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these install paths are not updated yet
vcs validate: error: argument --input: can't open
'/usr/local/Cellar/ignition-garden/0.999.999~0~20220414/share/gz/gz-garden/gazebodistro/collection-garden.yaml':
[Errno 2] No such file or directory:
'/usr/local/Cellar/ignition-garden/0.999.999~0~20220414/share/gz/gz-garden/gazebodistro/collection-garden.yaml'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we haven't migrated IGN_DATA_INSTALL_DIR
yet. This was future-proofing. I understood no bottles were being built yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the garden formula is a special case; we have a nightly job to build that formula and run its test. I had forgotten about this when saying that tests were only used when building bottles. I'll submit a small PR to fix this formula only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.