gz-ionic: new formula in ionic #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
83 tasks
scpeters
changed the title
Signed-off-by: Steve Peters <[email protected]>
scpeters
requested changes
Oct 23, 2023
Formula/gz-ionic.rb
Outdated
| head "https://github.com/gazebosim/gz-ionic.git", branch: "main" | ||
|
|
||
| depends_on "cmake" => :build | ||
| depends_on "[email protected]" => [:build, :test] |
There was a problem hiding this comment.
this can be removed if we don't install and test the yaml
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
@scpeters I've addressed your feedback. I'm not sure why CI is failing though. |
|
the latest brew test error could be due to having a gz-ionic file in Aliases. Let me try removing that |
Signed-off-by: Ian Chen <[email protected]>
scpeters
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebo-tooling/release-tools#1027