Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tethys_equipped face North by default #154

Merged
merged 10 commits into from
Feb 3, 2022
Merged

tethys_equipped face North by default #154

merged 10 commits into from
Feb 3, 2022

Conversation

chapulina
Copy link
Contributor

This PR updates the tethys_equipped model so that it faces North by default, i.e. zero orientation means it faces North, to match what the controller expects. Before this PR, the model was facing West by default.

Before this PR After this PR
image image

Summary:

  • ⚠️ tethys_equipped faces North / +Y, but tethys by itself still faces -X / West
  • The state message has been updated to publish pos and RPH in NED (see tests)
  • ⚠️ The model's base link (canonical link) still faces the model's -X, which is the world's -Y at pose zero

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in! I like the suffixing of coordinate systems to variable names, gonna start doing that. This looks good to me.

lrauv_ignition_plugins/src/TethysCommPlugin.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Thanks for the review, @arjo129 . I've addressed all of your comments. This PR builds on top of #143 because without that the spawn test would fail. I think it's best to merge that one first so that it's easier to review.

Signed-off-by: Louise Poubel <[email protected]>
Base automatically changed from chapulina/spawn_orientation to main February 3, 2022 01:33
@arjo129 arjo129 merged commit 3ecc9e0 into main Feb 3, 2022
@arjo129 arjo129 deleted the chapulina/ned branch February 3, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants