-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example ROS bridge for electro-hydraulic PTO #13
Conversation
Signed-off-by: Louise Poubel <[email protected]>
I could see loading plugins a la carte for a general use, configurable product of which MBARI's is a specific implementation. It would be nice to easily launch individual plugins for testing in isolation (or superposition) when modeling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Louise Poubel <[email protected]>
I'll open a separate PR breaking this apart 👍🏽 |
|
Signed-off-by: Michael Anderson <[email protected]>
* Setup profiler Signed-off-by: Louise Poubel <[email protected]> * first pass at cleanup / optimization Signed-off-by: Michael Anderson <[email protected]> * colcon test Signed-off-by: Michael Anderson <[email protected]> * magic number Signed-off-by: Michael Anderson <[email protected]> * update documentation Signed-off-by: Michael Anderson <[email protected]> * documentation; whitespace tweaks; status todo Signed-off-by: Michael Anderson <[email protected]> * copy spring controller and ignore build for now Signed-off-by: Michael Anderson <[email protected]> * documentation Signed-off-by: Michael Anderson <[email protected]> * WIP; need to fix build; COLCON_IGNORE not being honored by cmake directory crawling Signed-off-by: Michael Anderson <[email protected]> * fixed compile Signed-off-by: Michael Anderson <[email protected]> * added PCRecord publishing; added PCWindCurrCommand service Signed-off-by: Michael Anderson <[email protected]> * added scale factor Signed-off-by: Michael Anderson <[email protected]> * colcon test Signed-off-by: Michael Anderson <[email protected]> * added retract and bias current Signed-off-by: Michael Anderson <[email protected]> * PR comments Signed-off-by: Michael Anderson <[email protected]> * remove status stuff in this PR Signed-off-by: Michael Anderson <[email protected]> * fix command timeouts Signed-off-by: Michael Anderson <[email protected]> * fix build Signed-off-by: Michael Anderson <[email protected]> * add noop controller Signed-off-by: Michael Anderson <[email protected]> * remove unused Signed-off-by: Michael Anderson <[email protected]> * colcon test Signed-off-by: Michael Anderson <[email protected]> * add pytest via launch Signed-off-by: Michael Anderson <[email protected]> * running gtest, gtest with ros and launch, gtest with pytest and launch Signed-off-by: Michael Anderson <[email protected]> * gitignore __pycache__ Signed-off-by: Michael Anderson <[email protected]> * unit tests pass Signed-off-by: Michael Anderson <[email protected]> * putting the pytest in launch.py for now Signed-off-by: Michael Anderson <[email protected]> * start with valve Signed-off-by: Michael Anderson <[email protected]> * added launch; added bounds for valve; added pump test and tweaked sdf Signed-off-by: Michael Anderson <[email protected]> * use text fixture Signed-off-by: Michael Anderson <[email protected]> * fix pump test iterations; test status flags for valve Signed-off-by: Michael Anderson <[email protected]> * add pump status checking; add comments Signed-off-by: Michael Anderson <[email protected]> * fix for #13 Signed-off-by: Michael Anderson <[email protected]> * tests pass; fix uncrustify Signed-off-by: Michael Anderson <[email protected]> * added pytest version of SC Pump command test Signed-off-by: Michael Anderson <[email protected]> * add dependencies Signed-off-by: Michael Anderson <[email protected]> * try to wait for /clock to complete before comparing sim and node clock Signed-off-by: Michael Anderson <[email protected]> * allow /clock to finish publish before compare Signed-off-by: Michael Anderson <[email protected]> * extending test timeout in CMakeLists.txt seems to let tests pass in CI Signed-off-by: Michael Anderson <[email protected]> * trying larger timeout Signed-off-by: Michael Anderson <[email protected]> * keep trying to fix timeouts Signed-off-by: Michael Anderson <[email protected]> * increase to absurd timeout Signed-off-by: Michael Anderson <[email protected]> * add minimal pytest for ignition.gazebo.TestFixture Signed-off-by: Michael Anderson <[email protected]> * put timeouts back to reasonable value Signed-off-by: Michael Anderson <[email protected]> * find a way around using ignition.gazebo.TestFixture for python tests Signed-off-by: Michael Anderson <[email protected]> * increase launch_test timeout for CI Signed-off-by: Michael Anderson <[email protected]> * CI computers are slow :( Signed-off-by: Michael Anderson <[email protected]> * adding valve launch_testing pytest; had to split test to re-run fixture_server Signed-off-by: Michael Anderson <[email protected]> * flake Signed-off-by: Michael Anderson <[email protected]> * Update sc_commands_ros_feedback.launch.py Increase timeout Co-authored-by: Louise Poubel <[email protected]>
Here's an example launch file that loads the electro-hydraulic PTO world and exposes all the Gazebo topics to ROS.
Try it out
Launch the world:
Check that topics are available with ROS:
Listen to a topic with ROS, for example:
Publish to a topic with ROS, for example:
Open question
I'm not sure if we're planning to expose the same topics for all worlds, or different worlds will expose different topics. Some things we may want to do: