Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding trefoil controller #130

Merged
merged 6 commits into from
Feb 18, 2023
Merged

Adding trefoil controller #130

merged 6 commits into from
Feb 18, 2023

Conversation

quarkytale
Copy link
Contributor

@quarkytale quarkytale commented Feb 10, 2023 •
edited
Loading

Trefoil controller for publishing IMU, Magnetometer, Sea pressure and other constants from TFRecord.msg

@quarkytale
setting up trefoil controller
8d45750 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale quarkytale linked an issue Feb 10, 2023 that may be closed by this pull request
Create controllers to simulate heave cone and battery messages #121
Closed
@quarkytale
magnetometer and constants
0b2c252 
Signed-off-by: Dharini Dutia <[email protected]>
@andermi
Copy link
Collaborator

andermi commented Feb 13, 2023

Made some comments... also, not sure why the no_inputs test is timing out all 10 retries

@andermi andermi closed this Feb 13, 2023
@andermi andermi reopened this Feb 13, 2023
@andermi
Copy link
Collaborator

andermi commented Feb 13, 2023

oops @ close with comment 😆

@quarkytale
publisher for magnetic field msg
75e812f 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale
sea pressure
08b8529 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale quarkytale marked this pull request as ready for review February 15, 2023 08:54
@andermi
Copy link
Collaborator

andermi commented Feb 15, 2023

LGTM after fixing uncrustify... also still not sure why the no_inputs test is failing in the PR CI

@quarkytale
fix uncrustify
724ba90 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale
using sim time
c0204c6 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale quarkytale merged commit 1b479a2 into main Feb 18, 2023
@quarkytale quarkytale deleted the trefoil_controller branch February 18, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andermi andermi andermi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create controllers to simulate heave cone and battery messages
2 participants
@quarkytale @andermi