Init latlon for world #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Anderson <[email protected]>
|
@hamilton8415 @quarkytale if one of you could push this one through quickly, I'd appreciate it. |
hamilton8415
approved these changes
May 16, 2023
There was a problem hiding this comment.
I haven't run and tested this, but looking at the files-changed it seems straightforward and low impact on anything we are doing, so happy to approve. I will say that I haven't yet looked at the lat/lon reported in the .csv files, other than to notice that they are always zero. Maybe related? We will see...
|
OK, I did run this and it runs fine, although with this version of _gz since the PR is against main, the .csv files aren't being created, so we will have to wait to see if lat/lon values appear. No problem... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was being spammed:
This PR adds a
spherical_coordinatesto the main world file to init world origin and the warning goes away.