Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use parent folder for FreeSurfaceHydrodynamics includes #156

Merged
merged 11 commits into from
Aug 31, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Aug 28, 2023

requires hamilton8415/FreeSurfaceHydrodynamics#5

Best practice to namespace library includes on the path.

@andermi andermi mentioned this pull request Aug 28, 2023
@andermi andermi changed the base branch from main to andermi/fix_ehpto_force August 30, 2023 20:53
Base automatically changed from andermi/fix_ehpto_force to main August 30, 2023 21:28
Copy link
Collaborator

@hamilton8415 hamilton8415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a tag 1.3.1 to the FreeSurfaceHydrodynamics, so I believe updating the tag from v1.3.0 to v1.3.1in build-and-test.sh could help with the tests passing.

Signed-off-by: Michael Anderson <[email protected]>
* update spring to match at-sea polytropic process

Signed-off-by: Michael Anderson <[email protected]>

* can now specify spring params per batch

Signed-off-by: Michael Anderson <[email protected]>

* tune spring to match atsea

Signed-off-by: Michael Anderson <[email protected]>

* add matrix_mode: False option to sim params yaml to allow vectorized mode

Signed-off-by: Michael Anderson <[email protected]>

---------

Signed-off-by: Michael Anderson <[email protected]>
@hamilton8415
Copy link
Collaborator

Darn tests...

@andermi andermi merged commit 0b34366 into main Aug 31, 2023
2 checks passed
@andermi andermi deleted the andermi/fix_fshydro_includes branch August 31, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants