-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use parent folder for FreeSurfaceHydrodynamics includes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Anderson <[email protected]>
Merged
Signed-off-by: Michael Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a tag 1.3.1 to the FreeSurfaceHydrodynamics, so I believe updating the tag from v1.3.0 to v1.3.1in build-and-test.sh could help with the tests passing.
Signed-off-by: Michael Anderson <[email protected]>
…mode (#158) Signed-off-by: Michael Anderson <[email protected]>
* update spring to match at-sea polytropic process Signed-off-by: Michael Anderson <[email protected]> * can now specify spring params per batch Signed-off-by: Michael Anderson <[email protected]> * tune spring to match atsea Signed-off-by: Michael Anderson <[email protected]> * add matrix_mode: False option to sim params yaml to allow vectorized mode Signed-off-by: Michael Anderson <[email protected]> --------- Signed-off-by: Michael Anderson <[email protected]>
hamilton8415
approved these changes
Aug 30, 2023
Darn tests... |
Signed-off-by: Michael Anderson <[email protected]>
…f/mbari_wec_gz into andermi/fix_fshydro_includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires hamilton8415/FreeSurfaceHydrodynamics#5
Best practice to namespace library includes on the path.