Debug flag for WaveBodyInteractions plugin #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
hamilton8415
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
This suits me fine. An alternative would be to comment out or even remove most of these debug messages. They were there for initial debug during development. Under the presumption that things are working as expected it'd be fine to remove them. There is a day when someone/I goes to add features related to multiple wave directions or similar, but they/I could add a lot of this back in which would probably be a useful an necessary exercise in understanding some of the details. This addition is a low priority...
andermi
added a commit
that referenced
this pull request
Sep 21, 2023
* update spring to match at-sea polytropic process Signed-off-by: Michael Anderson <[email protected]> * can now specify spring params per batch Signed-off-by: Michael Anderson <[email protected]> * tune spring to match atsea Signed-off-by: Michael Anderson <[email protected]> * ros2 service for incwave height; issues so replace LinearIncidentWave with non-pointer in ECM Signed-off-by: Michael Anderson <[email protected]> * use parent folder for FreeSurfaceHydrodynamics includes Signed-off-by: Michael Anderson <[email protected]> * add matrix_mode: False option to sim params yaml to allow vectorized mode Signed-off-by: Michael Anderson <[email protected]> * added latent data and tweaked incwaveheight Signed-off-by: Michael Anderson <[email protected]> * can specify incwaveheight points in sdf Signed-off-by: Michael Anderson <[email protected]> * added spring and pto (still need a couple pto losses) Signed-off-by: Michael Anderson <[email protected]> * linters Signed-off-by: Michael Anderson <[email protected]> * linters Signed-off-by: Michael Anderson <[email protected]> * add ehpto force Signed-off-by: Michael Anderson <[email protected]> * added forces from piston friction and wavebodyinteraction Signed-off-by: Michael Anderson <[email protected]> * Debug flag for WaveBodyInteractions plugin (#160) * temporarily checkout andermi/latent_data in mbari_wec_utils for CI Signed-off-by: Michael Anderson <[email protected]> * linters Signed-off-by: Michael Anderson <[email protected]> * add gas mass and eff_v/m; comment units; use buoy_utils/constants.h in spring Signed-off-by: Michael Anderson <[email protected]> * fix last push Signed-off-by: Michael Anderson <[email protected]> * fix latent_data pub Signed-off-by: Michael Anderson <[email protected]> * Added Shaft Mechanical Power to Latent Data * Added additional loss terms to electrohydraulic latent data * Resolved signs with supplied hydraulic power * Fixed bug in relief valve loss computation * Adjusted fields * Fixed formating for linters * Add wave body total power to latent data (#165) * added wave_body total forces Signed-off-by: Michael Anderson <[email protected]> * added buoy pose and twist to latent data Signed-off-by: Michael Anderson <[email protected]> * added pose/twist to operator== for latent data Signed-off-by: Michael Anderson <[email protected]> * init pose/twist Signed-off-by: Michael Anderson <[email protected]> * linters Signed-off-by: Michael Anderson <[email protected]> --------- Signed-off-by: Michael Anderson <[email protected]> --------- Signed-off-by: Michael Anderson <[email protected]> Co-authored-by: Andrew Hamilton <[email protected]> Co-authored-by: Andrew Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if we want to see debug statements from another plugin, WaveBodyInteractions produces so much output, that it is difficult to see other prints. Also, logging easily fills up disk space in
~/.gz/sim/log. So, move gzdbg messages for the WaveBodyInteractions plugin behind debug flag.