Porting electro-hydraulic plugin #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
approved these changes
Apr 13, 2022
| @@ -0,0 +1,6 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
This fork is duplicate here and in buoy_examples:
https://github.com/osrf/buoy_examples/tree/main/include/JustInterp
It would be nice to avoid the duplication. There were a few things we had to do there to suppress linter warnings, for example. We also added a copyright header with a link to the original library.
I started a thread on Slack about this. For now, I think this PR can stay as is and we can make modifications in follow up PRs.
There was a problem hiding this comment.
Sounds good, will create a ticket
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting plugins from bitbucket.
Install the project using instructions in buoy_entrypoint and run either