Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing colcon warning #65

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Removing colcon warning #65

merged 2 commits into from
Jun 25, 2022

Conversation

quarkytale
Copy link
Contributor

This should take care of the warning while building buoy_tests package.

[75.327s] WARNING:colcon.colcon_cmake.task.cmake.build:Could not run installation step for package 'buoy_tests' because it has no 'install' target

Modified the BUILD_TESTING flag logic. Ideally, return() should bring back control to the parent CMakeLists.txt, but here there is none which might be causing the issue.

@quarkytale
revert BUILD_TESTING logic
a454329 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale quarkytale mentioned this pull request Jun 24, 2022
Merged
@quarkytale
Copy link
Contributor Author

Tests are passing on my system after sourcing the workspace

chapulina
chapulina approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @quarkytale!

.github/workflows/build-and-test.sh Show resolved Hide resolved
@quarkytale quarkytale merged commit be6d3fd into main Jun 25, 2022
@quarkytale quarkytale deleted the quarkytale/tests_warning branch June 25, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@andermi andermi Awaiting requested review from andermi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quarkytale @chapulina