Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stub unused services #68

Merged
merged 44 commits into from
Jul 12, 2022
Merged

stub unused services #68

merged 44 commits into from
Jul 12, 2022

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Jun 28, 2022

Addresses #67

chapulina and others added 29 commits May 31, 2022 16:09
@chapulina
Setup profiler
c426a72 
Signed-off-by: Louise Poubel <[email protected]>
@andermi
first pass at cleanup / optimization
13c1115 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge remote-tracking branch 'origin/chapulina/profiler' into andermi…
a6f14ea 
…/spring_cleaning

Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/spring_cleaning
af91a75
@andermi
colcon test
4932dc1 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
magic number
4804c8b 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/spring_cleaning
bca4f6f
@andermi
update documentation
40e06b5 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/spring_cleaning' of https://github.com/osrf/buo…
bc4f6d9 
…y_sim into andermi/spring_cleaning
@andermi
documentation; whitespace tweaks; status todo
e0998a3 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
copy spring controller and ignore build for now
c175f75 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
documentation
1bc8c28 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/spring_cleaning' into andermi/power_controller
a98bc1e
@andermi
WIP; need to fix build; COLCON_IGNORE not being honored by cmake dire…
acc378b 
…ctory crawling

Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/power_controller
228a1a7 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fixed compile
e3a6353 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added PCRecord publishing; added PCWindCurrCommand service
7bf5751 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added scale factor
730b94a 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
colcon test
b9269dc 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added retract and bias current
52ea87e 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/power_controller
f72672b
@andermi
PR comments
249eb52 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/power_controller' of https://github.com/osrf/bu…
9a651fc 
…oy_sim into andermi/power_controller
@andermi
remove status stuff in this PR
fb3cef4 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fix command timeouts
eed528c 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fix build
9f660b2 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/power_controller' into andermi/stub_unused_serv…
da05d57 
…ices
@andermi
add noop controller
1bd69a2 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
remove unused
5ac87b3 
Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi requested a review from chapulina June 28, 2022 22:38
@andermi
fix conflict with main
3c2c75f 
Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi linked an issue Jun 29, 2022 that may be closed by this pull request
Add all service stubs in sim #67
Closed
18 tasks
@andermi
Copy link
Collaborator Author

andermi commented Jun 29, 2022 •
edited
Loading

needs NOT_IMPLEMENTED field from osrf/mbari_wec_utils#13

@andermi
Copy link
Collaborator Author

andermi commented Jun 29, 2022

ok, so I pulled in #57 and #69 to get some unit testing and requires osrf/mbari_wec_utils#13

The basic test is for both python and cpp building on the basic test in #56 but I added an implementation of the buoy_msgs/interface to check power_controller data published on /pc_record from the ROS2 gazebo plugin

@andermi
Copy link
Collaborator Author

andermi commented Jun 29, 2022

here -> 1bd69a2
I added a NoOpController ROS2 node plugin to service all unimplemented buoy commands

andermi and others added 4 commits June 30, 2022 11:50
@andermi
fix merge
75fc5e1 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
putting the pytest in launch.py for now
0586231 
Signed-off-by: Michael Anderson <[email protected]>
@chapulina
merged from main
52eed16 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
merged from main
ddc2560 
Signed-off-by: Louise Poubel <[email protected]>
Base automatically changed from andermi/power_controller to main July 8, 2022 22:39
@chapulina
merged from main
9f27256 
Signed-off-by: Louise Poubel <[email protected]>
chapulina
chapulina approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a few trivial comments.

+1 for the macros 😄

buoy_gazebo/src/controllers/ServicesNotImplemented/NoOpController.cpp Outdated Show resolved Hide resolved
buoy_gazebo/src/controllers/ServicesNotImplemented/NoOpController.cpp Outdated Show resolved Hide resolved
buoy_gazebo/src/controllers/ServicesNotImplemented/NoOpController.cpp Outdated Show resolved Hide resolved
@chapulina chapulina mentioned this pull request Jul 8, 2022
Merged
@andermi
fix prints
86cdac2 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
flake
2c7fa59 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Copy link
Collaborator Author

andermi commented Jul 12, 2022 •
edited
Loading

@chapulina I can't figure out what's going on with the failing checks. For some reason, it looks like the sim isn't running for 5000 iterations in CI, but it passes in my workspace when I have andermi/stub_unused_services for buoy_sim, and main for buoy_msgs and buoy_examples

Edit: I guess I fixed it

@andermi
try to get tests running
318e6a3 
Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi merged commit 638d0b2 into main Jul 12, 2022
@andermi andermi deleted the andermi/stub_unused_services branch July 12, 2022 22:27
This was referenced Jul 13, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@andermi andermi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add all service stubs in sim
2 participants
@andermi @chapulina