Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Status Bit-field to EHPTO & PowerController #71

Merged
merged 49 commits into from
Aug 1, 2022
Merged

Add Status Bit-field to EHPTO & PowerController #71

merged 49 commits into from
Aug 1, 2022

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Jul 8, 2022 •
edited by quarkytale
Loading

addresses #61

TODO:

  • define bit-field
  • [ ] implement status in plugin/controller

Not going to implement the status right now. Maybe down the road if needed.

chapulina and others added 30 commits May 31, 2022 16:09
@chapulina
Setup profiler
c426a72 
Signed-off-by: Louise Poubel <[email protected]>
@andermi
first pass at cleanup / optimization
13c1115 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge remote-tracking branch 'origin/chapulina/profiler' into andermi…
a6f14ea 
…/spring_cleaning

Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/spring_cleaning
af91a75
@andermi
colcon test
4932dc1 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
magic number
4804c8b 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/spring_cleaning
bca4f6f
@andermi
update documentation
40e06b5 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/spring_cleaning' of https://github.com/osrf/buo…
bc4f6d9 
…y_sim into andermi/spring_cleaning
@andermi
documentation; whitespace tweaks; status todo
e0998a3 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
copy spring controller and ignore build for now
c175f75 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
documentation
1bc8c28 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/spring_cleaning' into andermi/power_controller
a98bc1e
@andermi
WIP; need to fix build; COLCON_IGNORE not being honored by cmake dire…
acc378b 
…ctory crawling

Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/power_controller
228a1a7 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fixed compile
e3a6353 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added PCRecord publishing; added PCWindCurrCommand service
7bf5751 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added scale factor
730b94a 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
colcon test
b9269dc 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added retract and bias current
52ea87e 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/power_controller
f72672b
@andermi
PR comments
249eb52 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/power_controller' of https://github.com/osrf/bu…
9a651fc 
…oy_sim into andermi/power_controller
@andermi
remove status stuff in this PR
fb3cef4 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fix command timeouts
eed528c 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fix build
9f660b2 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/power_controller' into andermi/stub_unused_serv…
da05d57 
…ices
@andermi
add noop controller
1bd69a2 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
remove unused
5ac87b3 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
colcon test
58be61a 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
running gtest, gtest with ros and launch, gtest with pytest and launch
c275014 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
gitignore __pycache__
b9538d6 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/enable_launch_test' into andermi/stub_unused_se…
4293987 
…rvices
@andermi
unit tests pass
661f7bc 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/add_sc_tests
072dc02
@andermi
putting the pytest in launch.py for now
0586231 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'andermi/stub_unused_services' into andermi/add_sc_tests
2cf1d95
@andermi
start with valve
d484a30 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
added launch; added bounds for valve; added pump test and tweaked sdf
a7be933 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
use text fixture
7e8a5e9 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
fix pump test iterations; test status flags for valve
a08f05e 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
add pump status checking; add comments
6cedcda 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
move Status class to utils as template; use in SpringState and EHPTOS…
9d75d1b 
…tate; define PowerStatusBits

Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi linked an issue Jul 8, 2022 that may be closed by this pull request
Add Status Bit-field to PowerController PCRecord #61
Closed
@andermi andermi marked this pull request as ready for review July 8, 2022 17:08
@andermi andermi mentioned this pull request Jul 12, 2022
Merged
Base automatically changed from andermi/add_sc_tests to main July 26, 2022 05:54
@andermi
remove todo
dd4bb8b 
Signed-off-by: Michael Anderson <[email protected]>
@andermi
Merge branch 'main' into andermi/power_status
1a674b1 
Signed-off-by: Michael Anderson <[email protected]>
@andermi andermi enabled auto-merge (squash) August 1, 2022 23:22
@andermi andermi merged commit e2ea9e0 into main Aug 1, 2022
@andermi andermi deleted the andermi/power_status branch August 1, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale quarkytale left review comments

@chapulina chapulina chapulina approved these changes

Assignees

@andermi andermi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Status Bit-field to PowerController PCRecord
3 participants
@andermi @chapulina @quarkytale