Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for custom vehicles #487

Open
M1chaelM opened this issue Jul 22, 2022 · 2 comments
Open

Improve support for custom vehicles #487

M1chaelM opened this issue Jul 22, 2022 · 2 comments

Comments

@M1chaelM
Copy link
Collaborator

Currently we support the WAMV and CORA platforms. We have seen several requests for guidance on adding new vehicles. See:

This issue could be partially resolved with a detailed tutorial, as suggested in #465. However, some aspects of our vehicle model are currently hard-coded to match the WAMV design (e.g. two cylindrical hulls) and even our mono-hull CORA vehicle is using this. In addition, some vehicles may require extending the thruster plugin's capabilities, as proposed in the following PRs:

We should support these features if possible, but we need to be mindful of any potential impacts on VRX competitors--in particular, it would be good to double check that any modifications which will propagate back to the WAMV are faithful to our theory of operations and don't have any unintended effects for the competition, or at least can be disabled if they do.

@acxz
Copy link

acxz commented Jul 23, 2022

Thanks for putting up this list @M1chaelM.

Can you also add the following PRs which increase/correct the fidelity of the simulator? These are listed in order of increasing fidelity.

@acxz
Copy link

acxz commented Jul 23, 2022

support these features if possible

I think this is evident based on the PRs submitted.

be mindful of any potential impacts on VRX competitors

For sure

double check that any modifications which will propagate back to the WAMV are faithful to our theory of operations

I would be willing to get on call with you to discuss the math behind the PRs

don't have any unintended effects for the competition

All PRs (Besides #496, #485, & #489) retain default values that do not change any behavior. The mentioned PRs fix the fluid density, (which is a very small change), and increase the accuracy in the buoyancy calculation. From the PRs the buoyancy has increased in simulation by about 100N (increase of only about 4%), but the visible behavior change of the vessel is not noticeably at all.

at least can be disabled if they do

Many changes are in the plugins and those portions can be selectively not loaded.

The above two concerns are specific to each feature and the relevant conversation and concerns should be had on the respective PRs/issues for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants