Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP: Read project_urls attribute from setup.py #509

Closed
Tracked by #4637
haikoschol opened this issue Apr 30, 2018 · 1 comment · Fixed by #5399
Closed
Tracked by #4637

PIP: Read project_urls attribute from setup.py #509

haikoschol opened this issue Apr 30, 2018 · 1 comment · Fixed by #5399
Labels
analyzer About the analyzer tool bug Issues that are considered to be bugs

Comments

@haikoschol
Copy link
Contributor

haikoschol commented Apr 30, 2018 •
edited by sschuberth
Loading

A VCS repository from which releases are created is preferrable to the location of a source artifact ("sdist" in Python lingo). There is a rarely used attribute in setup.py where this information can be recorded. Make sure this information is captured, if it is present.
@haikoschol haikoschol added bug Issues that are considered to be bugs analyzer About the analyzer tool labels Apr 30, 2018
@sschuberth
Copy link
Member

Note that project_urls is a map of strings to strings, with not really standardized keys / values. For example, the key might be called "Source" or "Source Code", and the value might be "https://github.com/pypa/sampleproject/", but there is no convention about whether the URL should be the VCS clone URL or the entry point for browsing the source code, which makes leveraging this attribute a bit hard.

@sschuberth sschuberth mentioned this issue Oct 28, 2021
Closed
10 tasks
mnonnenmacher added a commit that referenced this issue May 27, 2022
@mnonnenmacher
Pip: Add more VCS fallback URLs for packages
a767aae 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes #509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher mentioned this issue May 27, 2022
Merged
mnonnenmacher added a commit that referenced this issue May 27, 2022
@mnonnenmacher
Pip: Add more VCS fallback URLs for packages
9922cd2 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes #509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue May 28, 2022
@mnonnenmacher
Pip: Add more VCS fallback URLs for packages
645e1c4 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes #509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue May 28, 2022
@mnonnenmacher
Pip: Add more VCS fallback URLs for packages
e753ff9 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes #509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue May 28, 2022
@mnonnenmacher
Pip: Add more VCS fallback URLs for packages
a8814fc 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes #509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
porsche-rbieniek pushed a commit to porsche-rbieniek/ort that referenced this issue Jun 24, 2022
@mnonnenmacher @porsche-rbieniek
Pip: Add more VCS fallback URLs for packages
61a370d 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes oss-review-toolkit#509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
porsche-rbieniek pushed a commit to porsche-rbieniek/ort that referenced this issue Jun 27, 2022
@mnonnenmacher @porsche-rbieniek
Pip: Add more VCS fallback URLs for packages
a2876d4 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes oss-review-toolkit#509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
porsche-rbieniek pushed a commit to porsche-rbieniek/ort that referenced this issue Jun 27, 2022
@mnonnenmacher @porsche-rbieniek
Pip: Add more VCS fallback URLs for packages
a4a9970 
Add more fields that could contain a link to the source code repository
as fallback URLs for Python packages.

Fixes oss-review-toolkit#509.

Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer About the analyzer tool bug Issues that are considered to be bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pip: Add more VCS fallback URLs for packages oss-review-toolkit/ort
2 participants
@sschuberth @haikoschol