Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip: Get rid of the pydep dependency #5247

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Pip: Get rid of the pydep dependency #5247

merged 3 commits into from
Apr 12, 2022

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

…thon 3.8

Python 3.6 was updated to Python 3.8 a while ago as part of [1].

[1]: #4899 (comment)

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested review from a team as code owners April 11, 2022 19:25
@sschuberth sschuberth enabled auto-merge (rebase) April 11, 2022 19:25
The original `pydep` tool is archived by now [1] and running it with
newer Python versions might cause problems [2]. So replace it by simply
"running" `setup.py` with the option for the metadata field to get.

Resolves #2816.

[1]: https://github.com/sourcegraph/pydep
[2]: #5159 (comment)

Signed-off-by: Sebastian Schuberth <[email protected]>
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #5247 (bb717a1) into main (1fdae7f) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

@@             Coverage Diff              @@
##               main    #5247      +/-   ##
============================================
- Coverage     72.27%   72.27%   -0.01%     
- Complexity     1947     1951       +4     
============================================
  Files           259      259              
  Lines         13846    13838       -8     
  Branches       1950     1955       +5     
============================================
- Hits          10007    10001       -6     
+ Misses         2806     2800       -6     
- Partials       1033     1037       +4     
Impacted Files Coverage Δ
analyzer/src/main/kotlin/managers/Pip.kt 72.23% <53.84%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fdae7f...bb717a1. Read the comment docs.

@sschuberth sschuberth merged commit 159f3cc into main Apr 12, 2022
@sschuberth sschuberth deleted the py-imps branch April 12, 2022 09:58
@sschuberth sschuberth added the release notes Changes that should be mentioned in release notes label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Changes that should be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants